Discussion:
Small code Suggestion
Jörg Schaible
2013-08-12 23:14:42 UTC
Permalink
Hi Ben,
Hi,
In the class: com.thoughtworks.xstream.io.xml.AbstractXppDriver I noticed
that exceptions are being caught without the inner exception being set,
try { ... } catch (XmlPullParserException e) {
throw new StreamException("Cannot create XmlPullParser");
}
try { ... } catch (XmlPullParserException e) {
throw new StreamException("Cannot create XmlPullParser", e);
}
I don't know about everyone else, but I find inner exceptions very useful
when debugging. There are 3 exceptions thrown in that class that discard
the information from the underlying cause. I haven't poked around
elsewhere.
Can you open a JIRA issue please?

Cheers,
Jörg

Loading...